This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
refactor!: dispatcher rewrite #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmreTech
added
p: medium
|
This PR will be recreated in the DisCatPy repo after the monorepo pr. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the dispatcher & events from the ground up.
Why?
The first approach wasn't well typed. Static type checkers had no way to check if the parameters in the function were correct or not according to the prototype. Using classes gets rid of this issue since static type checkers understand those (obviously). Additionally, the first dispatcher didn't support consumers, and I really want to implement consumers not just for discatpy but for other discatcore users.